Fix derive(Deserialize) on void enum #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Sep 28, 2023
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Merged master into this to pick up the tests, then noticed that derive(Serialize) is similarly broken, because (for some reason) references to uninhabitable types are not considered uninhabited for the purposes of exhaustiveness checking.
I would request review from @coolreader18 , but this is their PR, so instead I'm approving and leaving for them to merge.
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
fix: undefined 'u' sql name -> 'a'
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes Addresses clockworklabs/SpacetimeDBPrivate#1786 and clockworklabs/com.clockworklabs.spacetimedbsdk#329. Marks messages as parsed from the background parsing thread, and then marks them as applied using a separate tracker once they are applied. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs ## Testsuite SpacetimeDB branch name: master ## Testing - [x] Testing against Bitcraft
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Description of Changes Addresses clockworklabs/SpacetimeDBPrivate#1786 and clockworklabs/com.clockworklabs.spacetimedbsdk#329. Marks messages as parsed from the background parsing thread, and then marks them as applied using a separate tracker once they are applied. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs ## Testsuite SpacetimeDB branch name: master ## Testing - [x] Testing against Bitcraft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
resolves #325
API and ABI
If the API is breaking, please state below what will break